Change in osmo-msc[master]: SMPP: Don't accept password or system-id exceeding spec length

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 10 06:50:37 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13930 )

Change subject: SMPP: Don't accept password or system-id exceeding spec length
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13930/1/src/libmsc/smpp_smsc.h
File src/libmsc/smpp_smsc.h:

https://gerrit.osmocom.org/#/c/13930/1/src/libmsc/smpp_smsc.h@16
PS1, Line 16: #define SMPP_SYS_ID_LEN	15
> Same define is defined in smpp_mirror.c, you want to fix that one too. […]
stictly speaking, that's not a bug fix.  SMPP_Mirror has no user-configurabe username and/or password, so unlike osmo-msc there is no situation where the user can configure something that will break in practise.  Having too large buffers is not a bug there.

So I think it's a separate cleanup that deserves a separate patch, at much lower priority.



-- 
To view, visit https://gerrit.osmocom.org/13930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81ef593e84bf1e15f6746386fc145495fae29354
Gerrit-Change-Number: 13930
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2019 06:50:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/87ac5e2b/attachment.html>


More information about the gerrit-log mailing list