Change in osmo-msc[master]: SMPP: Don't accept password or system-id exceeding spec length

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu May 9 08:54:43 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13930 )

Change subject: SMPP: Don't accept password or system-id exceeding spec length
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/13930/1/src/libmsc/smpp_smsc.h
File src/libmsc/smpp_smsc.h:

https://gerrit.osmocom.org/#/c/13930/1/src/libmsc/smpp_smsc.h@16
PS1, Line 16: #define SMPP_SYS_ID_LEN	15
Same define is defined in smpp_mirror.c, you want to fix that one too.

Furthermore, smpp_mirror.c uses wrong define for password:

src/utils/smpp_mirror.c
24:#define SMPP_SYS_ID_LEN      16
43:     char system_id[SMPP_SYS_ID_LEN+1];
44:     char password[SMPP_SYS_ID_LEN+1];



-- 
To view, visit https://gerrit.osmocom.org/13930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81ef593e84bf1e15f6746386fc145495fae29354
Gerrit-Change-Number: 13930
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2019 08:54:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/f0657735/attachment.html>


More information about the gerrit-log mailing list