Change in osmo-ccid-firmware[master]: switch UART_debug to ASYNC

Kévin Redon gerrit-no-reply at lists.osmocom.org
Thu May 9 13:39:27 UTC 2019


Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/13673 )

Change subject: switch UART_debug to ASYNC
......................................................................


Patch Set 9:

> I still don't like the fact that this looses serial output pretty
 > much all the time (e.g. if you type 'help' at the command line).

fixed in https://gerrit.osmocom.org/#/c/osmo-ccid-firmware/+/13677/ patchset 10. the new async lib with tx buffer is now blocking when the buffer is full.
I did not implemented a warning for buffer "overflow", but the buffer is already quite large and I saw it blocking only with very large text (e.g. help).


-- 
To view, visit https://gerrit.osmocom.org/13673
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If18883e96f336aa9f6b11607859260da5e1503c7
Gerrit-Change-Number: 13673
Gerrit-PatchSet: 9
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Kévin Redon <kredon at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2019 13:39:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/d8721687/attachment.html>


More information about the gerrit-log mailing list