Change in osmo-ccid-firmware[master]: switch UART_debug to ASYNC

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 2 15:02:46 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13673 )

Change subject: switch UART_debug to ASYNC
......................................................................


Patch Set 9: Code-Review-1

I still don't like the fact that this looses serial output pretty much all the time (e.g. if you type 'help' at the command line).

I would prefer if the mechanism would use buffered writes, but end up blocking in case the write buffer is full - rather than simply dropping log output

We can introduce a global counter of how often this blocking occurs and possibly use that counter (manually) to increase the #define for the buffer size if needed.


-- 
To view, visit https://gerrit.osmocom.org/13673
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If18883e96f336aa9f6b11607859260da5e1503c7
Gerrit-Change-Number: 13673
Gerrit-PatchSet: 9
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Thu, 02 May 2019 15:02:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190502/b58eac15/attachment.html>


More information about the gerrit-log mailing list