Change in osmo-mgw[master]: mgcp-cli: Change osmo_mgcpc_ep_fsm name to avoid collision with old o...

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed May 8 12:04:12 UTC 2019


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13912


Change subject: mgcp-cli: Change osmo_mgcpc_ep_fsm name to avoid collision with old osmo-bsc
......................................................................

mgcp-cli: Change osmo_mgcpc_ep_fsm name to avoid collision with old osmo-bsc

Recent commit moved mgw_endpoint_fsm from osmo-bsc.git here as
osmo_mgcpc_ep_fsm. Some API name changes were applied to avoid
collisions, but FSM was kept and it is registered during startup with
__attribute__((constructor)). As a result, with old osmo-bsc (+tests)
try to allocate its copy of mgw_endpoint_fsm, it fails because that name
is already registered.

Fixes: 538d2c53d90074267e7a70a90c773baa03d6ec04
Change-Id: I694ce58baa43f536b7e594b003edc891f029aa4a
---
M src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/12/13912/1

diff --git a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
index 0e59f58..a9bab87 100644
--- a/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
+++ b/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
@@ -862,7 +862,7 @@
 }
 
 static struct osmo_fsm osmo_mgcpc_ep_fsm = {
-	.name = "mgw-endpoint",
+	.name = "mgw-endp",
 	.states = osmo_mgcpc_ep_fsm_states,
 	.num_states = ARRAY_SIZE(osmo_mgcpc_ep_fsm_states),
 	.log_subsys = DLMGCP,

-- 
To view, visit https://gerrit.osmocom.org/13912
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I694ce58baa43f536b7e594b003edc891f029aa4a
Gerrit-Change-Number: 13912
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/c2a8f447/attachment.html>


More information about the gerrit-log mailing list