Change in osmo-bts[master]: handle NULL return from rate_ctr_group_alloc()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 8 22:17:19 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13911 )

Change subject: handle NULL return from rate_ctr_group_alloc()
......................................................................

handle NULL return from rate_ctr_group_alloc()

Change-Id: I2170e400e47369e9171af4c7361aa2177fea1174
Related: OS#3701
---
M src/common/bts.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/bts.c b/src/common/bts.c
index 8c2b2fe..5851e9b 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -122,6 +122,10 @@
 	bts->agch_queue.length = 0;
 
 	bts->ctrs = rate_ctr_group_alloc(bts, &bts_ctrg_desc, bts->nr);
+	if (!bts->ctrs) {
+		llist_del(&bts->list);
+		return -1;
+	}
 
 	/* enable management with default levels,
 	 * raise threshold to GSM_BTS_AGCH_QUEUE_THRESH_LEVEL_DISABLE to

-- 
To view, visit https://gerrit.osmocom.org/13911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2170e400e47369e9171af4c7361aa2177fea1174
Gerrit-Change-Number: 13911
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/60942086/attachment.htm>


More information about the gerrit-log mailing list