Change in osmo-msc[master]: libmsc/gsm_04_08.c: fix: print proper length value

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed May 8 10:22:16 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13906


Change subject: libmsc/gsm_04_08.c: fix: print proper length value
......................................................................

libmsc/gsm_04_08.c: fix: print proper length value

Since in parse_umts_auth_resp() we are checking the length of
GSM48_IE_AUTH_RES_EXT TLV, we need to print its length, but
not the length of the whole L3.

Change-Id: I2bfebce6d017be834bfe7628ffa2b341eb82c11c
---
M src/libmsc/gsm_04_08.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/13906/1

diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 4be42e9..32a7b7f 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -967,9 +967,9 @@
 
 	if (data_len < 3) {
 		LOGP(DMM, LOGL_ERROR,
-		     "%s: MM AUTHENTICATION RESPONSE:"
-		     " l3 length invalid: %u\n",
-		     vlr_subscr_name(conn->vsub), msgb_l3len(msg));
+		     "%s: MM AUTHENTICATION RESPONSE: "
+		     "GSM48_IE_AUTH_RES_EXT TLV's length %u < 3\n"
+		     vlr_subscr_name(conn->vsub), data_len);
 		return -EINVAL;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/13906
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bfebce6d017be834bfe7628ffa2b341eb82c11c
Gerrit-Change-Number: 13906
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190508/562098e1/attachment.html>


More information about the gerrit-log mailing list