<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13906">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_04_08.c: fix: print proper length value<br><br>Since in parse_umts_auth_resp() we are checking the length of<br>GSM48_IE_AUTH_RES_EXT TLV, we need to print its length, but<br>not the length of the whole L3.<br><br>Change-Id: I2bfebce6d017be834bfe7628ffa2b341eb82c11c<br>---<br>M src/libmsc/gsm_04_08.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/13906/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c</span><br><span>index 4be42e9..32a7b7f 100644</span><br><span>--- a/src/libmsc/gsm_04_08.c</span><br><span>+++ b/src/libmsc/gsm_04_08.c</span><br><span>@@ -967,9 +967,9 @@</span><br><span> </span><br><span>       if (data_len < 3) {</span><br><span>               LOGP(DMM, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                "%s: MM AUTHENTICATION RESPONSE:"</span><br><span style="color: hsl(0, 100%, 40%);">-                     " l3 length invalid: %u\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                   vlr_subscr_name(conn->vsub), msgb_l3len(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+                     "%s: MM AUTHENTICATION RESPONSE: "</span><br><span style="color: hsl(120, 100%, 40%);">+                  "GSM48_IE_AUTH_RES_EXT TLV's length %u < 3\n"</span><br><span style="color: hsl(120, 100%, 40%);">+                vlr_subscr_name(conn->vsub), data_len);</span><br><span>              return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13906">change 13906</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13906"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2bfebce6d017be834bfe7628ffa2b341eb82c11c </div>
<div style="display:none"> Gerrit-Change-Number: 13906 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>