Change in libosmocore[master]: fsm: support graceful osmo_fsm_inst_term() cascades

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 27 07:36:47 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13392 )

Change subject: fsm: support graceful osmo_fsm_inst_term() cascades
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.osmocom.org/#/c/13392/4//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13392/4//COMMIT_MSG@33
PS4, Line 33: Note: at least osmo-msc's msc_vlr_tests' expected output needs to be adjusted
            : after merging this, because of logging changes for FSM deallocations
this is *very* bad.  Is there any way we can avoid this?


https://gerrit.osmocom.org/#/c/13392/4//COMMIT_MSG@36
PS4, Line 36: This patch's mechanism is not thread safe. It might be made thread safe
            : if the new global variable osmo_fsm_inst_terminating_root were handled
            : per-thread instead of once globally.
please mark the related global variables as __thread right away. It doesn't cost us anything, AFAIK.


https://gerrit.osmocom.org/#/c/13392/4/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:

https://gerrit.osmocom.org/#/c/13392/4/include/osmocom/core/fsm.h@118
PS4, Line 118: bool terminating;
as this breaks ABI, please add TODO-RELEASE entry.


https://gerrit.osmocom.org/#/c/13392/4/src/fsm.c
File src/fsm.c:

https://gerrit.osmocom.org/#/c/13392/4/src/fsm.c@397
PS4, Line 397: static int osmo_fsm_inst_terminating = 0;
             : static struct osmo_fsm_inst *osmo_fsm_inst_terminating_root = NULL;
mark as __thread, possibly even put both in a struct and then have a "static __thread struct" for tidyness?



-- 
To view, visit https://gerrit.osmocom.org/13392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eda67540a1cd444491beb7856b9fcd0a3143b18
Gerrit-Change-Number: 13392
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 27 Mar 2019 07:36:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/2baf18e4/attachment.html>


More information about the gerrit-log mailing list