Change in libosmocore[master]: fsm_dealloc_test: no need for ST_DESTROYING

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Mar 24 06:02:50 UTC 2019


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13393


Change subject: fsm_dealloc_test: no need for ST_DESTROYING
......................................................................

fsm_dealloc_test: no need for ST_DESTROYING

Now that fsm.c avoids re-entering osmo_fsm_inst_term() twice and gracefully
handles FSM instance deallocations for termination cascades, it is actually no
longer needed to keep a separate ST_DESTROYING state. ST_DESTROYING was used to
flag deallocation and prevent enterint osmo_fsm_inst_term() twice, which works
only in a very limited range of scenarios.

Remove ST_DESTROYING from fsm_dealloc_test.c to show that all tested scenarios
still clean up gracefully.

Change-Id: I05354e6cad9b82ba474fa50ffd41d481b3c697b4
---
M tests/fsm/fsm_dealloc_test.c
M tests/fsm/fsm_dealloc_test.err
2 files changed, 1,585 insertions(+), 1,864 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/93/13393/1


-- 
To view, visit https://gerrit.osmocom.org/13393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05354e6cad9b82ba474fa50ffd41d481b3c697b4
Gerrit-Change-Number: 13393
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190324/577260c8/attachment.html>


More information about the gerrit-log mailing list