This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13402 ) Change subject: Update MCS selection for retransmission ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13402/1/src/coding_scheme.c File src/coding_scheme.c: https://gerrit.osmocom.org/#/c/13402/1/src/coding_scheme.c@131 PS1, Line 131: /* FIXME: take into account padding and special cases of commanded MCS (MCS-6-9 and MCS-5-7) */ commanded MCS? do you mean demanded_mcs? https://gerrit.osmocom.org/#/c/13402/1/src/coding_scheme.c@136 PS1, Line 136: OSMO_ASSERT(NUM_SCHEMES - MCS1 == 9); That should be actually a compile-time assert. Have a look at "_Static_assert": https://en.cppreference.com/w/c/language/_Static_assert It seems for c++ "static_assert" is used instead. May be worth adding an OSMO_STATIC_ASSERT() macro in libosmocore to make it automatically c/c++ compatible, as explained in https://stackoverflow.com/a/54993033 -- To view, visit https://gerrit.osmocom.org/13402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia73baeefee7a58834f0fc50e3b8bf8d5e3eb7815 Gerrit-Change-Number: 13402 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2019 16:37:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190325/2b26fcf0/attachment.htm>