Change in osmo-pcu[master]: Update MCS selection for retransmission

Max gerrit-no-reply at lists.osmocom.org
Wed Mar 27 12:48:42 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13402 )

Change subject: Update MCS selection for retransmission
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/13402/1/src/coding_scheme.c
File src/coding_scheme.c:

https://gerrit.osmocom.org/#/c/13402/1/src/coding_scheme.c@136
PS1, Line 136: 	OSMO_ASSERT(NUM_SCHEMES - MCS1 == 9);
> May be worth adding an OSMO_STATIC_ASSERT() macro in libosmocore

Excellent idea! Please update this code once the macro is available in libosmocore.



-- 
To view, visit https://gerrit.osmocom.org/13402
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia73baeefee7a58834f0fc50e3b8bf8d5e3eb7815
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Mar 2019 12:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190327/912a0ff3/attachment.html>


More information about the gerrit-log mailing list