Change in libosmocore[master]: core/linuxlist.h: fix and unify Doxygen documentation
gerrit-no-reply at lists.osmocom.org
Mon Mar 25 15:06:58 UTC 2019
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13398 )
Change subject: core/linuxlist.h: fix and unify Doxygen documentation
Patch Set 1:
PS1, Line 50: /*! Define a new llist_head pointing to another llist_head.
> another is confusing here, specially because immediatelly afterwards it' used to point to itself in […]
PS1, Line 69: * Insert a new entry between two known consecutive entries.
> No need for extra line. You can start it with "/*! Insert", see functions below.
This is an internal function, so we probably don't need to have any Doxygen documentation for it. I just made it look similar to __llist_del's documentation.
PS1, Line 85: * \param _new a new entry to be added.
> "the entry to be added".
PS1, Line 86: * \param head head of linked list to add it after.
> "add it after" is quite misleading here. […]
To view, visit https://gerrit.osmocom.org/13398
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Mar 2019 15:06:58 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log