Change in osmocom-bb[master]: trxcon: update trx_udp_open()

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Mar 21 18:03:57 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13367 )

Change subject: trxcon: update trx_udp_open()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c
File src/host/trxcon/trx_if.c:

https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c@612
PS1, Line 612: bool is_ctrl,
> This change makes the function useless for anything else than TRXC and TRXD. […]
Alternatively, we can introduce an enumerated list of interfaces, and just pass an interface type here. So, we would also avoid passing both *ofd and *cb, and moreover just accept the base port instead of port_local / port remote, and do the final calculations here. I prefer this solution.



-- 
To view, visit https://gerrit.osmocom.org/13367
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b01879f6ea468941e5dab5b46492be8fe5730d
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Mar 2019 18:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190321/a8638bda/attachment.html>


More information about the gerrit-log mailing list