Change in osmocom-bb[master]: trxcon: update trx_udp_open()

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Mar 21 17:58:07 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13367 )

Change subject: trxcon: update trx_udp_open()
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c
File src/host/trxcon/trx_if.c:

https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c@612
PS1, Line 612: bool is_ctrl,
This change makes the function useless for anything else than TRXC and TRXD. I was thinking about (re)introducing the clock interface, so let's avoid this please.

As a possible solution, you can keep passing of the call-back function and just pass the interface name as a separate parameter, e.g. const char *name.


https://gerrit.osmocom.org/#/c/13367/1/src/host/trxcon/trx_if.c@630
PS1, Line 630: LOGL_NOTICE
Looks more like LOGL_INFO for me. I know, the existing code is not perfect, and LOGL_NOTICE is used most of the time. But let's consider LOGL_NOTICE as something more important than host / port information, and closer to error.



-- 
To view, visit https://gerrit.osmocom.org/13367
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b01879f6ea468941e5dab5b46492be8fe5730d
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Mar 2019 17:58:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190321/14bdf8e0/attachment.html>


More information about the gerrit-log mailing list