Change in osmocom-bb[master]: trxcon: use helper to add l1ctl_info_dl

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Mar 21 13:01:29 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13354 )

Change subject: trxcon: use helper to add l1ctl_info_dl
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c
File src/host/trxcon/l1ctl.c:

https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@141
PS1, Line 141: add_info_dl
Not a merge blocker, but I would prefer 'put_dl_info_hdr'.


https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@143
PS1, Line 143: sizeof(struct l1ctl_info_dl);
When I was writing this, I didn't know that we can do:

  sizeof(*dl)

Now I know, and recommend this ;)


https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@148
PS1, Line 148: Compose
Do we really compose anything here? Let's just say 'init'.



-- 
To view, visit https://gerrit.osmocom.org/13354
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5b81f1fcd2984136e553a93735ea5456d2b3df
Gerrit-Change-Number: 13354
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 13:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190321/edfb55d3/attachment.html>


More information about the gerrit-log mailing list