<p><a href="https://gerrit.osmocom.org/13354">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c">File src/host/trxcon/l1ctl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@141">Patch Set #1, Line 141:</a> <code style="font-family:monospace,monospace">add_info_dl</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not a merge blocker, but I would prefer 'put_dl_info_hdr'.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@143">Patch Set #1, Line 143:</a> <code style="font-family:monospace,monospace">sizeof(struct l1ctl_info_dl);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">When I was writing this, I didn't know that we can do:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  sizeof(*dl)</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Now I know, and recommend this ;)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13354/1/src/host/trxcon/l1ctl.c@148">Patch Set #1, Line 148:</a> <code style="font-family:monospace,monospace">Compose</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we really compose anything here? Let's just say 'init'.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/13354">change 13354</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13354"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0b5b81f1fcd2984136e553a93735ea5456d2b3df </div>
<div style="display:none"> Gerrit-Change-Number: 13354 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Mar 2019 13:01:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>