Change in libosmo-netif[master]: tests: AM_LDFLAGS = -noinstall for all tests

osmith gerrit-no-reply at lists.osmocom.org
Thu Mar 14 10:00:50 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13241 )

Change subject: tests: AM_LDFLAGS = -noinstall for all tests
......................................................................


Patch Set 2:

> Personally I'd prefer to just enable '-no-install' globally for all the tests by default and be done with it.

Good idea, updated the patch to do that.

> I'm not sure with what the "no-install" LDFLAGS do, and I would therefore (humbly) guess that I'm not the only one. It might be worth one sentence inthe commit log.

Commit message updated to include a description.


-- 
To view, visit https://gerrit.osmocom.org/13241
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d
Gerrit-Change-Number: 13241
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Alexander Huemer <alexander.huemer at xx.vu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: steve-m <steve at steve-m.de>
Gerrit-Comment-Date: Thu, 14 Mar 2019 10:00:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190314/b410d436/attachment.html>


More information about the gerrit-log mailing list