Change in libosmo-netif[master]: tests: AM_LDFLAGS = -noinstall for all tests

osmith gerrit-no-reply at lists.osmocom.org
Thu Mar 14 09:56:37 UTC 2019


Hello dexter, Alexander Huemer, steve-m, Max, Harald Welte, Jenkins Builder, Pablo Neira Ayuso, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/13241

to look at the new patch set (#2).

Change subject: tests: AM_LDFLAGS = -noinstall for all tests
......................................................................

tests: AM_LDFLAGS = -noinstall for all tests

Fix a symbol lookup error when building a new test on systems where
a previous libosmonetfix.so is installed. Symptoms described here in
detail: https://osmocom.org/issues/3812#note-10

-no-install causes libtool to generate output files that link against
libraries in the build tree, instead of linking against the future
installation paths and generating a wrapper script. The wrapper script
should override the library paths, but at least on Debian, it does not
work as it should. Test binaries won't be installed anyway, so we can
safely use -no-install and work around the problem.

See also:
https://autotools.io/libtool/wrappers.html
https://www.gnu.org/software/libtool/manual/html_node/Link-mode.html

Related: OS#3812
Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d
---
M tests/Makefile.am
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/41/13241/2
-- 
To view, visit https://gerrit.osmocom.org/13241
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94ccff42dfba71aaf59bb30ca312db0bac58c27d
Gerrit-Change-Number: 13241
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Alexander Huemer <alexander.huemer at xx.vu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: steve-m <steve at steve-m.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190314/09fdfc72/attachment.html>


More information about the gerrit-log mailing list