Change in osmo-bsc[master]: handover_fsm: copy old S15_S0 to new lchan

dexter gerrit-no-reply at
Mon Mar 11 13:18:49 UTC 2019

dexter has uploaded this change for review. (

Change subject: handover_fsm: copy old S15_S0 to new lchan

handover_fsm: copy old S15_S0 to new lchan

When a new lchan is selected during handover, some of the properties of
the old lchan are inherited by the new lchan. At the moment S15-S0 is
not not inherited so that the value for those bits will always be 0x0000
for the new lchan. Since those bits also define the active set AMR codec
the channel activation will fail because 0x0000 is invalid (active set
with zero rates)

Change-Id: Ifd470397e99985394634da1bb13ccfc5041984d2
Related: OS#3503
M src/osmo-bsc/handover_fsm.c
M tests/handover/handover_test.c
2 files changed, 4 insertions(+), 2 deletions(-)

  git pull ssh:// refs/changes/00/13200/1

diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 30297f6..a3d25d6 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -362,6 +362,7 @@
 		.msc_assigned_cic = conn->ho.inter_bsc_in.msc_assigned_cic,
 		.re_use_mgw_endpoint_from_lchan = conn->lchan,
 		.wait_before_switching_rtp = true,
+		.s15_s0 = conn->lchan->,
 	lchan_activate(ho->new_lchan, &info);
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index 6217ca3..cd3b749 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -276,9 +276,10 @@
 		lchan->tch_mode = GSM48_CMODE_SPEECH_V1;
 	else if (!strcasecmp(codec, "EFR") && full_rate)
 		lchan->tch_mode = GSM48_CMODE_SPEECH_EFR;
-	else if (!strcasecmp(codec, "AMR"))
+	else if (!strcasecmp(codec, "AMR")) {
 		lchan->tch_mode = GSM48_CMODE_SPEECH_AMR;
-	else {
+		lchan-> = 0x0002;
+	} else {
 		printf("Given codec unknown\n");

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd470397e99985394634da1bb13ccfc5041984d2
Gerrit-Change-Number: 13200
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list