<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13200">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_fsm: copy old S15_S0 to new lchan<br><br>When a new lchan is selected during handover, some of the properties of<br>the old lchan are inherited by the new lchan. At the moment S15-S0 is<br>not not inherited so that the value for those bits will always be 0x0000<br>for the new lchan. Since those bits also define the active set AMR codec<br>the channel activation will fail because 0x0000 is invalid (active set<br>with zero rates)<br><br>Change-Id: Ifd470397e99985394634da1bb13ccfc5041984d2<br>Related: OS#3503<br>---<br>M src/osmo-bsc/handover_fsm.c<br>M tests/handover/handover_test.c<br>2 files changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/00/13200/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index 30297f6..a3d25d6 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -362,6 +362,7 @@</span><br><span>             .msc_assigned_cic = conn->ho.inter_bsc_in.msc_assigned_cic,</span><br><span>               .re_use_mgw_endpoint_from_lchan = conn->lchan,</span><br><span>            .wait_before_switching_rtp = true,</span><br><span style="color: hsl(120, 100%, 40%);">+            .s15_s0 = conn->lchan->activate.info.s15_s0,</span><br><span>   };</span><br><span> </span><br><span>       lchan_activate(ho->new_lchan, &info);</span><br><span>diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c</span><br><span>index 6217ca3..cd3b749 100644</span><br><span>--- a/tests/handover/handover_test.c</span><br><span>+++ b/tests/handover/handover_test.c</span><br><span>@@ -276,9 +276,10 @@</span><br><span>             lchan->tch_mode = GSM48_CMODE_SPEECH_V1;</span><br><span>  else if (!strcasecmp(codec, "EFR") && full_rate)</span><br><span>           lchan->tch_mode = GSM48_CMODE_SPEECH_EFR;</span><br><span style="color: hsl(0, 100%, 40%);">-    else if (!strcasecmp(codec, "AMR"))</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (!strcasecmp(codec, "AMR")) {</span><br><span>              lchan->tch_mode = GSM48_CMODE_SPEECH_AMR;</span><br><span style="color: hsl(0, 100%, 40%);">-    else {</span><br><span style="color: hsl(120, 100%, 40%);">+                lchan->activate.info.s15_s0 = 0x0002;</span><br><span style="color: hsl(120, 100%, 40%);">+      } else {</span><br><span>             printf("Given codec unknown\n");</span><br><span>           exit(EXIT_FAILURE);</span><br><span>  }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13200">change 13200</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13200"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifd470397e99985394634da1bb13ccfc5041984d2 </div>
<div style="display:none"> Gerrit-Change-Number: 13200 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>