Change in osmo-msc[master]: SMS queue: properly log failed attempts number

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Mar 7 15:41:48 UTC 2019


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13154 )

Change subject: SMS queue: properly log failed attempts number
......................................................................

SMS queue: properly log failed attempts number

Change-Id: I16f2d29855eb715eccbdc5def225f43c110fab8e
---
M src/libmsc/sms_queue.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c
index c5d2fc2..c924dde 100644
--- a/src/libmsc/sms_queue.c
+++ b/src/libmsc/sms_queue.c
@@ -151,11 +151,12 @@
 	struct gsm_network *net = pending->vsub->vlr->user_ctx;
 	struct gsm_sms_queue *smsq;
 
+	pending->failed_attempts++;
 	LOGP(DLSMS, LOGL_NOTICE, "Sending SMS %llu failed %d times.\n",
 	     pending->sms_id, pending->failed_attempts);
 
 	smsq = net->sms_queue;
-	if (++pending->failed_attempts < smsq->max_fail)
+	if (pending->failed_attempts < smsq->max_fail)
 		return sms_pending_resend(pending);
 
 	sms_pending_free(pending);

-- 
To view, visit https://gerrit.osmocom.org/13154
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16f2d29855eb715eccbdc5def225f43c110fab8e
Gerrit-Change-Number: 13154
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190307/57ebb204/attachment.html>


More information about the gerrit-log mailing list