<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13154">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">SMS queue: properly log failed attempts number<br><br>Change-Id: I16f2d29855eb715eccbdc5def225f43c110fab8e<br>---<br>M src/libmsc/sms_queue.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c</span><br><span>index c5d2fc2..c924dde 100644</span><br><span>--- a/src/libmsc/sms_queue.c</span><br><span>+++ b/src/libmsc/sms_queue.c</span><br><span>@@ -151,11 +151,12 @@</span><br><span>  struct gsm_network *net = pending->vsub->vlr->user_ctx;</span><br><span>     struct gsm_sms_queue *smsq;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+       pending->failed_attempts++;</span><br><span>       LOGP(DLSMS, LOGL_NOTICE, "Sending SMS %llu failed %d times.\n",</span><br><span>         pending->sms_id, pending->failed_attempts);</span><br><span> </span><br><span>   smsq = net->sms_queue;</span><br><span style="color: hsl(0, 100%, 40%);">-       if (++pending->failed_attempts < smsq->max_fail)</span><br><span style="color: hsl(120, 100%, 40%);">+     if (pending->failed_attempts < smsq->max_fail)</span><br><span>              return sms_pending_resend(pending);</span><br><span> </span><br><span>      sms_pending_free(pending);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13154">change 13154</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13154"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I16f2d29855eb715eccbdc5def225f43c110fab8e </div>
<div style="display:none"> Gerrit-Change-Number: 13154 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>