Change in osmo-msc[master]: gsm_04_11_gsup.c: drop unused conn lookup

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Mar 7 15:41:47 UTC 2019


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13153 )

Change subject: gsm_04_11_gsup.c: drop unused conn lookup
......................................................................

gsm_04_11_gsup.c: drop unused conn lookup

An earlier code state used the conn to lookup the transaction, but this is now
done by vsub. Hence the conn lookup is not used and not needed.

conn is no longer used since 36c44b210059bd75059008913ad05976dfef7d7e,
change-Id I093f36d63e671e50e54fc6236e97a777cc6da77b,
"transaction: change arguments of trans_find_by_sm_rp_mr()"

Change-Id: Ia878d70138c883cb1a1d983516aff83efa6488ce
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 8b1225e..eb092ae 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -121,7 +121,6 @@
 	struct vlr_instance *vlr;
 	struct gsm_network *net;
 	struct gsm_trans *trans;
-	struct ran_conn *conn;
 	const char *msg_name;
 	bool msg_is_err;
 
@@ -165,16 +164,6 @@
 	if (msg_is_err && !gsup_msg->sm_rp_cause)
 		goto msg_error;
 
-	/* Attempt to find a DTAP-connection */
-	conn = connection_for_subscr(vsub);
-	if (!conn) {
-		/* FIXME: should we establish it then? */
-		LOGP(DLSMS, LOGL_NOTICE, "No connection found for %s, "
-			"ignoring %s-%s message...\n", vlr_subscr_name(vsub),
-			msg_name, msg_is_err ? "Err" : "Res");
-		return -EIO; /* TODO: notify sender about that? */
-	}
-
 	/* Attempt to find DTAP-transaction */
 	trans = trans_find_by_sm_rp_mr(net, vsub, *(gsup_msg->sm_rp_mr));
 	if (!trans) {

-- 
To view, visit https://gerrit.osmocom.org/13153
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia878d70138c883cb1a1d983516aff83efa6488ce
Gerrit-Change-Number: 13153
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190307/792a5fe8/attachment.html>


More information about the gerrit-log mailing list