<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13153">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_04_11_gsup.c: drop unused conn lookup<br><br>An earlier code state used the conn to lookup the transaction, but this is now<br>done by vsub. Hence the conn lookup is not used and not needed.<br><br>conn is no longer used since 36c44b210059bd75059008913ad05976dfef7d7e,<br>change-Id I093f36d63e671e50e54fc6236e97a777cc6da77b,<br>"transaction: change arguments of trans_find_by_sm_rp_mr()"<br><br>Change-Id: Ia878d70138c883cb1a1d983516aff83efa6488ce<br>---<br>M src/libmsc/gsm_04_11_gsup.c<br>1 file changed, 0 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c</span><br><span>index 8b1225e..eb092ae 100644</span><br><span>--- a/src/libmsc/gsm_04_11_gsup.c</span><br><span>+++ b/src/libmsc/gsm_04_11_gsup.c</span><br><span>@@ -121,7 +121,6 @@</span><br><span>    struct vlr_instance *vlr;</span><br><span>    struct gsm_network *net;</span><br><span>     struct gsm_trans *trans;</span><br><span style="color: hsl(0, 100%, 40%);">-        struct ran_conn *conn;</span><br><span>       const char *msg_name;</span><br><span>        bool msg_is_err;</span><br><span> </span><br><span>@@ -165,16 +164,6 @@</span><br><span>  if (msg_is_err && !gsup_msg->sm_rp_cause)</span><br><span>                 goto msg_error;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     /* Attempt to find a DTAP-connection */</span><br><span style="color: hsl(0, 100%, 40%);">- conn = connection_for_subscr(vsub);</span><br><span style="color: hsl(0, 100%, 40%);">-     if (!conn) {</span><br><span style="color: hsl(0, 100%, 40%);">-            /* FIXME: should we establish it then? */</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DLSMS, LOGL_NOTICE, "No connection found for %s, "</span><br><span style="color: hsl(0, 100%, 40%);">-                       "ignoring %s-%s message...\n", vlr_subscr_name(vsub),</span><br><span style="color: hsl(0, 100%, 40%);">-                 msg_name, msg_is_err ? "Err" : "Res");</span><br><span style="color: hsl(0, 100%, 40%);">-              return -EIO; /* TODO: notify sender about that? */</span><br><span style="color: hsl(0, 100%, 40%);">-      }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /* Attempt to find DTAP-transaction */</span><br><span>       trans = trans_find_by_sm_rp_mr(net, vsub, *(gsup_msg->sm_rp_mr));</span><br><span>         if (!trans) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13153">change 13153</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13153"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia878d70138c883cb1a1d983516aff83efa6488ce </div>
<div style="display:none"> Gerrit-Change-Number: 13153 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>