Change in osmo-gsm-tester[master]: nitb_netreg_mass: Allow a suite to configure num subscriber

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Mar 5 17:40:22 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13042 )

Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/13042/4/src/osmo_gsm_tester/ms_osmo_mobile.py
File src/osmo_gsm_tester/ms_osmo_mobile.py:

https://gerrit.osmocom.org/#/c/13042/4/src/osmo_gsm_tester/ms_osmo_mobile.py@33
PS4, Line 33:             return "00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00"
Is this needed for later using imsi_ki_gen afaiu?


https://gerrit.osmocom.org/#/c/13042/4/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

https://gerrit.osmocom.org/#/c/13042/4/src/osmo_gsm_tester/suite.py@347
PS4, Line 347:     def all_modems(self):
I precisely wanted to avoid having more functions by having the generic one, since suite.py is already quite big (some stuff should be moved somewhere else, but of course not related). I'd prefer you using all_resources(suite.modem) instead and removing it, but fine.



-- 
To view, visit https://gerrit.osmocom.org/13042
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9fd560c2924731e4fd6eea5aaf3ad565cb4ef52
Gerrit-Change-Number: 13042
Gerrit-PatchSet: 4
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2019 17:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/214d45e8/attachment.html>


More information about the gerrit-log mailing list