Change in osmo-gsm-tester[master]: nitb_netreg_mass: Allow a suite to configure num subscriber

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Mar 5 16:25:47 UTC 2019


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/13042 )

Change subject: nitb_netreg_mass: Allow a suite to configure num subscriber
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/#/c/13042/3/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

https://gerrit.osmocom.org/#/c/13042/3/src/osmo_gsm_tester/suite.py@341
PS3, Line 341:     def modems(self, count):
> We could do the same for this method actually (see below).
Let's do this another day. I guess all_modems can get an optional count argument.


https://gerrit.osmocom.org/#/c/13042/3/src/osmo_gsm_tester/suite.py@347
PS3, Line 347:     def all_modems(self):
> Can we make this generic?:  […]
I am implementing all_modems around it as I prefer expressive APIs.


https://gerrit.osmocom.org/#/c/13042/3/suites/nitb_netreg_mass/register_default_mass.py
File suites/nitb_netreg_mass/register_default_mass.py:

https://gerrit.osmocom.org/#/c/13042/3/suites/nitb_netreg_mass/register_default_mass.py@20
PS3, Line 20: # Configure all MS that are available to this test.
> avilable: typo.
Done



-- 
To view, visit https://gerrit.osmocom.org/13042
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9fd560c2924731e4fd6eea5aaf3ad565cb4ef52
Gerrit-Change-Number: 13042
Gerrit-PatchSet: 4
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2019 16:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190305/414e3704/attachment.html>


More information about the gerrit-log mailing list