Change in ...libosmocore[master]: Makefile.am: don't delete example.xml, vtydoc.xsd
gerrit-no-reply at lists.osmocom.org
Fri Jun 28 11:50:52 UTC 2019
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14626 )
Change subject: Makefile.am: don't delete example.xml, vtydoc.xsd
Patch Set 1: Code-Review+1
PS1, Line 13: Related: OS#3986
> Yes, this is the correct ticket: https://osmocom.org/issues/3986: […]
Sorry my bad, I had the filling I was looking at #3986 but apparently I was looking at another ticket (strange, I actually verified the number twice. Maybe I was looking at wrong redmine instance).
PS1, Line 15:
> Correct me if I'm wrong, but we don't seem to do that in libosmocore git log so far (git log | grep) […]
Sorry again, I added a typo there, I meant "Fixes:". It is sometimes used, see for instance: git log | grep "Fixes:"
Fixes: 40def49ac4b8babbd1b17c232137ce50a428706b ("libosmocodec: implement ECU (Error Concealment Unit) for FR")
This syntax is quite used in the kernel in order to be able to avoid backporting broken commits without its follow-up fix ups.
I'm not forcing it since we didn't discuss about it, just sharing with you what I think is a good practice.
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14626
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 11:50:52 +0000
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log