Change in ...libosmocore[master]: Makefile.am: don't delete example.xml, vtydoc.xsd

osmith gerrit-no-reply at lists.osmocom.org
Fri Jun 28 11:24:28 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14626 )

Change subject: Makefile.am: don't delete example.xml, vtydoc.xsd
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/14626/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/#/c/14626/1//COMMIT_MSG@13 
PS1, Line 13: Related: OS#3986
> Are you sure this ticket is correct? I don't think so.
Yes, this is the correct ticket: https://osmocom.org/issues/3986:

"build process removes doc/vty/{example.xml,vtydoc.xsd}"


https://gerrit.osmocom.org/#/c/14626/1//COMMIT_MSG@15 
PS1, Line 15: 
> It's useful to have a "Fixed: <git commit hash>" tag here when a commit specifically fixes one commi […]
Correct me if I'm wrong, but we don't seem to do that in libosmocore git log so far (git log | grep), and we are usually referencing other commits by their gerrit change-id, not by their commit hash.

So if you don't mind, I'd rather stick to what is defined here: https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards#Have-meaningful-descriptions-in-your-patches

If it is important, I suggest discussing on the ML if we want to do this with all fixup commits from now on on, and then add it to the wiki page.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14626
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I884398c5e834ae2fac0af8c9b52d65bb3ceacb2d
Gerrit-Change-Number: 14626
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Jun 2019 11:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190628/c18e0d1b/attachment.html>


More information about the gerrit-log mailing list