Change in ...libosmocore[master]: bitvec: bitvec_get_uint() should return an unsigned int

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jun 23 07:59:52 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14577 )

Change subject: bitvec: bitvec_get_uint() should return an unsigned int
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14577/2/src/bitvec.c 
File src/bitvec.c:

https://gerrit.osmocom.org/#/c/14577/2/src/bitvec.c@278 
PS2, Line 278: if (bit < 0)
             : 			return bit;
> Assigned an int with negative value and casting it to an unsigned will have an interesting behaviour.

I think we would just get some high value close to UINT_MAX.

> How should we fix it?

Let's first investigate what's your motivation to use unsigned here? Is there a chance that the value range of regular int would not be enough? The commit message also lacks any details...



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14577
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2d50d375ccf63ecb45061682ede0b46b6087d11a
Gerrit-Change-Number: 14577
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Sun, 23 Jun 2019 07:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190623/4947c682/attachment.html>


More information about the gerrit-log mailing list