Change in ...libosmocore[master]: bitvec: bitvec_get_uint() should return an unsigned int

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sun Jun 23 07:42:07 UTC 2019


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14577 )

Change subject: bitvec: bitvec_get_uint() should return an unsigned int
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14577/2/src/bitvec.c 
File src/bitvec.c:

https://gerrit.osmocom.org/#/c/14577/2/src/bitvec.c@278 
PS2, Line 278: if (bit < 0)
             : 			return bit;
> I know what I meant to write ;)
I did not saw this branch.
How should we fix it?

Assigned an int with negative value and casting it to an unsigned will have an interesting behaviour. Even in libosmocore it's not used that way.
Should we introduce a new function which have a pointer to the return value?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14577
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2d50d375ccf63ecb45061682ede0b46b6087d11a
Gerrit-Change-Number: 14577
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Sun, 23 Jun 2019 07:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190623/eba36404/attachment.html>


More information about the gerrit-log mailing list