Change in ...osmo-ccid-firmware[master]: CCID (minor): remove unused variables

Kévin Redon gerrit-no-reply at lists.osmocom.org
Thu Jun 13 13:10:14 UTC 2019


Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/14435


Change subject: CCID (minor): remove unused variables
......................................................................

CCID (minor): remove unused variables

Change-Id: Iaf5e13574c27a6f4b8efa541ac908dde452d1dcf
---
M ccid/ccid_device.c
1 file changed, 3 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/35/14435/1

diff --git a/ccid/ccid_device.c b/ccid/ccid_device.c
index 346f77d..da2d7bb 100644
--- a/ccid/ccid_device.c
+++ b/ccid/ccid_device.c
@@ -397,7 +397,6 @@
 static int ccid_handle_get_slot_status(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->get_slot_status.hdr.bSeq;
 	struct msgb *resp;
 
@@ -411,7 +410,6 @@
 static int ccid_handle_icc_power_on(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 
 	/* handle this asynchronously */
 	cs->ci->slot_ops->icc_power_on_async(cs, msg, &u->icc_power_on);
@@ -422,7 +420,6 @@
 static int ccid_handle_icc_power_off(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->icc_power_off.hdr.bSeq;
 	struct msgb *resp;
 
@@ -435,7 +432,6 @@
 static int ccid_handle_xfr_block(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 
 	/* handle this asynchronously */
 	cs->ci->slot_ops->xfr_block_async(cs, msg, &u->xfr_block);
@@ -446,7 +442,6 @@
 static int ccid_handle_get_parameters(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->get_parameters.hdr.bSeq;
 	struct msgb *resp;
 
@@ -459,7 +454,6 @@
 static int ccid_handle_reset_parameters(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->reset_parameters.hdr.bSeq;
 	struct msgb *resp;
 
@@ -477,7 +471,6 @@
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
 	const struct ccid_pc_to_rdr_set_parameters *spar = &u->set_parameters;
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->set_parameters.hdr.bSeq;
 	struct ccid_pars_decoded pars_dec;
 	struct msgb *resp;
@@ -518,7 +511,6 @@
 static int ccid_handle_escape(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->escape.hdr.bSeq;
 	struct msgb *resp;
 
@@ -530,7 +522,6 @@
 static int ccid_handle_icc_clock(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->icc_clock.hdr.bSeq;
 	struct msgb *resp;
 
@@ -543,7 +534,6 @@
 static int ccid_handle_t0apdu(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->t0apdu.hdr.bSeq;
 	struct msgb *resp;
 
@@ -557,7 +547,6 @@
 static int ccid_handle_secure(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->secure.hdr.bSeq;
 	struct msgb *resp;
 
@@ -570,7 +559,6 @@
 static int ccid_handle_mechanical(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->mechanical.hdr.bSeq;
 	struct msgb *resp;
 
@@ -582,7 +570,6 @@
 static int ccid_handle_abort(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->abort.hdr.bSeq;
 	struct msgb *resp;
 
@@ -611,7 +598,6 @@
 static int ccid_handle_set_rate_and_clock(struct ccid_slot *cs, struct msgb *msg)
 {
 	const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);
-	const struct ccid_header *ch = (const struct ccid_header *) u;
 	uint8_t seq = u->set_rate_and_clock.hdr.bSeq;
 	uint32_t freq_hz = osmo_load32le(&u->set_rate_and_clock.dwClockFrequency);
 	uint32_t rate_bps = osmo_load32le(&u->set_rate_and_clock.dwDataRate);
@@ -772,13 +758,13 @@
 {
 	uint16_t w_value = osmo_load16le(&req->wValue);
 	uint8_t slot_nr = w_value & 0xff;
-	uint8_t seq = w_value >> 8;
-	struct ccid_slot *cs;
+	/* uint8_t seq = w_value >> 8; */
+	/* struct ccid_slot *cs; */
 
 	if (slot_nr >= ARRAY_SIZE(ci->slot))
 		return CCID_CTRL_RET_INVALID;
 
-	cs = &ci->slot[slot_nr];
+	/* cs = &ci->slot[slot_nr]; */
 
 	LOGP(DCCID, LOGL_NOTICE, "Not handling PC_to_RDR_Abort; please implement it\n");
 	/* Upon receiving the Control pipe ABORT request the CCID should check

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/14435
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Iaf5e13574c27a6f4b8efa541ac908dde452d1dcf
Gerrit-Change-Number: 14435
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190613/04168d38/attachment.html>


More information about the gerrit-log mailing list