<p>Kévin Redon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/14435">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CCID (minor): remove unused variables<br><br>Change-Id: Iaf5e13574c27a6f4b8efa541ac908dde452d1dcf<br>---<br>M ccid/ccid_device.c<br>1 file changed, 3 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/35/14435/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid/ccid_device.c b/ccid/ccid_device.c</span><br><span>index 346f77d..da2d7bb 100644</span><br><span>--- a/ccid/ccid_device.c</span><br><span>+++ b/ccid/ccid_device.c</span><br><span>@@ -397,7 +397,6 @@</span><br><span> static int ccid_handle_get_slot_status(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->get_slot_status.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -411,7 +410,6 @@</span><br><span> static int ccid_handle_icc_power_on(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> </span><br><span> /* handle this asynchronously */</span><br><span> cs->ci->slot_ops->icc_power_on_async(cs, msg, &u->icc_power_on);</span><br><span>@@ -422,7 +420,6 @@</span><br><span> static int ccid_handle_icc_power_off(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->icc_power_off.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -435,7 +432,6 @@</span><br><span> static int ccid_handle_xfr_block(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> </span><br><span> /* handle this asynchronously */</span><br><span> cs->ci->slot_ops->xfr_block_async(cs, msg, &u->xfr_block);</span><br><span>@@ -446,7 +442,6 @@</span><br><span> static int ccid_handle_get_parameters(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->get_parameters.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -459,7 +454,6 @@</span><br><span> static int ccid_handle_reset_parameters(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->reset_parameters.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -477,7 +471,6 @@</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span> const struct ccid_pc_to_rdr_set_parameters *spar = &u->set_parameters;</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->set_parameters.hdr.bSeq;</span><br><span> struct ccid_pars_decoded pars_dec;</span><br><span> struct msgb *resp;</span><br><span>@@ -518,7 +511,6 @@</span><br><span> static int ccid_handle_escape(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->escape.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -530,7 +522,6 @@</span><br><span> static int ccid_handle_icc_clock(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->icc_clock.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -543,7 +534,6 @@</span><br><span> static int ccid_handle_t0apdu(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->t0apdu.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -557,7 +547,6 @@</span><br><span> static int ccid_handle_secure(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->secure.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -570,7 +559,6 @@</span><br><span> static int ccid_handle_mechanical(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->mechanical.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -582,7 +570,6 @@</span><br><span> static int ccid_handle_abort(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->abort.hdr.bSeq;</span><br><span> struct msgb *resp;</span><br><span> </span><br><span>@@ -611,7 +598,6 @@</span><br><span> static int ccid_handle_set_rate_and_clock(struct ccid_slot *cs, struct msgb *msg)</span><br><span> {</span><br><span> const union ccid_pc_to_rdr *u = msgb_ccid_out(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ccid_header *ch = (const struct ccid_header *) u;</span><br><span> uint8_t seq = u->set_rate_and_clock.hdr.bSeq;</span><br><span> uint32_t freq_hz = osmo_load32le(&u->set_rate_and_clock.dwClockFrequency);</span><br><span> uint32_t rate_bps = osmo_load32le(&u->set_rate_and_clock.dwDataRate);</span><br><span>@@ -772,13 +758,13 @@</span><br><span> {</span><br><span> uint16_t w_value = osmo_load16le(&req->wValue);</span><br><span> uint8_t slot_nr = w_value & 0xff;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t seq = w_value >> 8;</span><br><span style="color: hsl(0, 100%, 40%);">- struct ccid_slot *cs;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* uint8_t seq = w_value >> 8; */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* struct ccid_slot *cs; */</span><br><span> </span><br><span> if (slot_nr >= ARRAY_SIZE(ci->slot))</span><br><span> return CCID_CTRL_RET_INVALID;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- cs = &ci->slot[slot_nr];</span><br><span style="color: hsl(120, 100%, 40%);">+ /* cs = &ci->slot[slot_nr]; */</span><br><span> </span><br><span> LOGP(DCCID, LOGL_NOTICE, "Not handling PC_to_RDR_Abort; please implement it\n");</span><br><span> /* Upon receiving the Control pipe ABORT request the CCID should check</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/14435">change 14435</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/14435"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaf5e13574c27a6f4b8efa541ac908dde452d1dcf </div>
<div style="display:none"> Gerrit-Change-Number: 14435 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>