Change in ...osmo-bts[master]: trx: Update documentation for fn-advance and rts-advance

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jun 2 19:21:44 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14334 )

Change subject: trx: Update documentation for fn-advance and rts-advance
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc 
File doc/manuals/chapters/bts-models.adoc:

https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc@254 
PS1, Line 254: clock
Looks a bit confusing. OsmoBTS actually does send DL bursts in advance, that's the purpose of 'fn-advance'.


https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc@256 
PS1, Line 256: J
typo


https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc@258 
PS1, Line 258: `N + fn-advance`
That would be too late, 'fn-advance' is actually being subtracted.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14334
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I83eff296bfb7acff9d8560b5346bd9791fe6e7d9
Gerrit-Change-Number: 14334
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 02 Jun 2019 19:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190602/e975ae84/attachment.html>


More information about the gerrit-log mailing list