<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/14334">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc">File doc/manuals/chapters/bts-models.adoc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc@254">Patch Set #1, Line 254:</a> <code style="font-family:monospace,monospace">clock</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks a bit confusing. OsmoBTS actually does send DL bursts in advance, that's the purpose of 'fn-advance'.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc@256">Patch Set #1, Line 256:</a> <code style="font-family:monospace,monospace">J</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">typo</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14334/1/doc/manuals/chapters/bts-models.adoc@258">Patch Set #1, Line 258:</a> <code style="font-family:monospace,monospace">`N + fn-advance`</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">That would be too late, 'fn-advance' is actually being subtracted.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/14334">change 14334</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/14334"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I83eff296bfb7acff9d8560b5346bd9791fe6e7d9 </div>
<div style="display:none"> Gerrit-Change-Number: 14334 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 02 Jun 2019 19:21:44 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>