Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE

neels gerrit-no-reply at lists.osmocom.org
Tue Jul 30 16:30:42 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 )

Change subject: Add support for MNCC HOLD/RETRIEVE
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c@697 
PS3, Line 697: 		"leg(%u) is req unhold.\n", leg->callref);
reason to call "retrieve" "unhold" all of a sudden?
funny: German word "der Unhold" https://dict.leo.org/german-english/der+Unhold


https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c@702 
PS3, Line 702: 	// the port of the original call
/* ... */



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9
Gerrit-Change-Number: 14996
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 16:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/0d883386/attachment.html>


More information about the gerrit-log mailing list