Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

neels gerrit-no-reply at lists.osmocom.org
Tue Jul 30 16:15:05 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )

Change subject: Add media mode parameter to sdp_create_file()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c 
File src/sdp.c:

https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c@191 
PS2, Line 191: 			mode_attribute = "";
(I'm not sure why, but at least by convention) end each case in 'break;'

BTW, there is no other enum value, is there? If it is never to be used, we might as well OSMO_ASSERT(false) here, to make it obvious that the code path is never used.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2
Gerrit-Change-Number: 14993
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 16:15:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/4d325cd1/attachment.html>


More information about the gerrit-log mailing list