Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file()

neels gerrit-no-reply at lists.osmocom.org
Tue Jul 30 16:03:43 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )

Change subject: Add media mode parameter to sdp_create_file()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14993/2/src/sip.c 
File src/sip.c:

https://gerrit.osmocom.org/#/c/14993/2/src/sip.c@389 
PS2, Line 389: 	sdp = sdp_create_file(leg, other, sdp_sendrecv);
before, this would send no "a=sendrecv", now it always does.

There's two ways we can go here:

a) keep the SIP headers unchanged, only send additional 'a=...' where new behavior is implemented.
i.e. in this patch keep the exact old behavior; but how?
Unfortunately sdp_mode_t has no "none" kind of enum value. We could somehow define -1 as "do not add any 'a=' attribute"? Or maybe add our own mode enum??

b) accept that we now always have an explicit "a=sendrecv" (or other mode) in all SIP headers.
Then this should be made clear in the commit log message.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2
Gerrit-Change-Number: 14993
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 16:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/594fa8f2/attachment.html>


More information about the gerrit-log mailing list