Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Jul 30 12:57:08 UTC 2019


Hello pespin, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/14972

to look at the new patch set (#3).

Change subject: vty/telnet_interface.c: log connection accept() / close() events
......................................................................

vty/telnet_interface.c: log connection accept() / close() events

Unfortunately, osmo_sock_get_name_buf() fails in telnet_close_client():

  DLGLOBAL INFO telnet_interface.c:130 Closing telnet connection <error-in-getsockname>

because getsockname(), getpeername(), and even close() fail with:

  "Bad file descriptor".

This looks like a bug of the existing code.

Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c
---
M src/vty/telnet_interface.c
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/14972/3
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c
Gerrit-Change-Number: 14972
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/42bfc23a/attachment.html>


More information about the gerrit-log mailing list