Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 30 12:42:25 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 )

Change subject: vty/telnet_interface.c: log connection accept() / close() events
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c 
File src/vty/telnet_interface.c:

https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c@129 
PS2, Line 129: 	osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, fd->fd);
> Are you sure? I checked the source code, and AFAICS osmo_sock_get_name_buf() always writes something […]
Implementation wise it does so, but I wouldn't rely on that. Handling return code is also expecteds by other people reading this code in the future, otherwise they might loose time checking if it's correct or not based on implementation.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c
Gerrit-Change-Number: 14972
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2019 12:42:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190730/79dedf89/attachment.html>


More information about the gerrit-log mailing list