Change in ...gr-gsm[master]: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_c...

vvvelichkov gerrit-no-reply at lists.osmocom.org
Mon Jul 29 19:08:54 UTC 2019


vvvelichkov has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14948 )

Change subject: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_ccch demappers blocks
......................................................................


Patch Set 2:

Hi Vadim,

> Patch Set 1:
> 
> In general, I am find with the proposed patch set. But instead of having magic calculations in the original code, I would rather follow the way of OsmoBTS, which I followed in trxcon:
> 
>   https://git.osmocom.org/osmocom-bb/tree/src/host/trxcon/sched_mframe.c
> 
> Ideally, we need to share this code somewhere in libosmogsm, so then it can be used by gr-gsm, and even by OsmoTRX.

Agree. My intention with this patch set was to fix demappers with minimal code changes and to add some tests.


-- 
To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14948
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-Change-Id: Ia6b3070c1085bcdda6d98fd94a89c6e0982e2aec
Gerrit-Change-Number: 14948
Gerrit-PatchSet: 2
Gerrit-Owner: vvvelichkov <vvvelichkov at gmail.com>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: vvvelichkov <vvvelichkov at gmail.com>
Gerrit-Comment-Date: Mon, 29 Jul 2019 19:08:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190729/ca98f72f/attachment.html>


More information about the gerrit-log mailing list