This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 ) Change subject: Add/fix help string for version option ...................................................................... Add/fix help string for version option osmo-sgsn was missing the help text of the -V option gb_proxy still thought of itself as OpenBSC Omit the name of the program in the help text to avoid such issues in the future. Related: OS#1720 Change-Id: Ib57694b6bff7c98a269dc4b4dbb7173349a57b81 --- M src/gprs/gb_proxy_main.c M src/gprs/gtphub_main.c M src/gprs/sgsn_main.c 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gprs/gb_proxy_main.c b/src/gprs/gb_proxy_main.c index 19fbbba..1e1aeac 100644 --- a/src/gprs/gb_proxy_main.c +++ b/src/gprs/gb_proxy_main.c @@ -140,7 +140,7 @@ printf(" -c --config-file filename The config file to use [%s]\n", CONFIG_FILE_DEFAULT); printf(" -s --disable-color\n"); printf(" -T --timestamp Prefix every log line with a timestamp\n"); - printf(" -V --version. Print the version of OpenBSC.\n"); + printf(" -V --version. Print the version.\n"); printf(" -e --log-level number. Set a global loglevel.\n"); } diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c index 585a3cb..6d470bd 100644 --- a/src/gprs/gtphub_main.c +++ b/src/gprs/gtphub_main.c @@ -238,7 +238,7 @@ printf(" -e,--log-level <nr> Set a global log level.\n"); printf(" -r,--restart-file <path> File for counting restarts [%s].\n", ccfg->restart_counter_file); - printf(" -V,--version Print the version number.\n"); + printf(" -V,--version Print the version.\n"); } static void list_categories(void) diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c index f12270d..3543517 100644 --- a/src/gprs/sgsn_main.c +++ b/src/gprs/sgsn_main.c @@ -209,6 +209,7 @@ { printf("Some useful help...\n"); printf(" -h --help\tthis text\n"); + printf(" -V --version\tPrint the version\n"); printf(" -D --daemonize\tFork the process into a background daemon\n"); printf(" -d option --debug\tenable Debugging\n"); printf(" -s --disable-color\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib57694b6bff7c98a269dc4b4dbb7173349a57b81 Gerrit-Change-Number: 14962 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190726/1c51e23b/attachment.htm>