Change in ...gr-gsm[master]: Fix sub_slot assignment in the universal_ctrl_chans_demapper block

Vasil Velichkov gerrit-no-reply at lists.osmocom.org
Thu Jul 25 21:30:26 UTC 2019


Hello Piotr Krysik, fixeria,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/gr-gsm/+/14946

to review the following change.


Change subject: Fix sub_slot assignment in the universal_ctrl_chans_demapper block
......................................................................

Fix sub_slot assignment in the universal_ctrl_chans_demapper block

3GPP TS 45.002 version 15.1.0 Release 15
Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5)
Table 4 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5)

Fixes the following tests:
qa_gsm_bcch_ccch_sdcch4_demapper.test_downlink
qa_gsm_sdcch8_demapper.test_downlink

Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348
---
M lib/demapping/universal_ctrl_chans_demapper_impl.cc
M python/qa_gsm_bcch_ccch_sdcch4_demapper.py
M python/qa_gsm_sdcch8_demapper.py
3 files changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/46/14946/1

diff --git a/lib/demapping/universal_ctrl_chans_demapper_impl.cc b/lib/demapping/universal_ctrl_chans_demapper_impl.cc
index 98bcc9c..a6ab956 100644
--- a/lib/demapping/universal_ctrl_chans_demapper_impl.cc
+++ b/lib/demapping/universal_ctrl_chans_demapper_impl.cc
@@ -140,7 +140,7 @@
             {
                 new_header->sub_type = ch_type;
             }
-            new_header->sub_slot = subslots[fn_mod51 + (51 * (frame_nr % 2))];
+            new_header->sub_slot = subslots[fn_mod102];
             
             if(fn_mod51>=fn51_start && fn_mod51<=fn51_stop)
             {
diff --git a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py
index f51c7bf..a3688c7 100644
--- a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py
+++ b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py
@@ -37,7 +37,6 @@
     def tearDown (self):
         self.tb = None
 
-    @unittest.expectedFailure
     def test_downlink (self):
         """
            BCCH_CCCH_SDCCH4 demapper downlink test
diff --git a/python/qa_gsm_sdcch8_demapper.py b/python/qa_gsm_sdcch8_demapper.py
index aacb1a8..b5c5ff5 100644
--- a/python/qa_gsm_sdcch8_demapper.py
+++ b/python/qa_gsm_sdcch8_demapper.py
@@ -37,7 +37,6 @@
     def tearDown (self):
         self.tb = None
 
-    @unittest.expectedFailure
     def test_downlink (self):
         """
            SDCCH8 demapper downlink test

-- 
To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348
Gerrit-Change-Number: 14946
Gerrit-PatchSet: 1
Gerrit-Owner: Vasil Velichkov <vvvelichkov at gmail.com>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190725/3ec4f3b6/attachment.html>


More information about the gerrit-log mailing list