<p>Vasil Velichkov would like Piotr Krysik and fixeria to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/gr-gsm/+/14946">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix sub_slot assignment in the universal_ctrl_chans_demapper block<br><br>3GPP TS 45.002 version 15.1.0 Release 15<br>Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5)<br>Table 4 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5)<br><br>Fixes the following tests:<br>qa_gsm_bcch_ccch_sdcch4_demapper.test_downlink<br>qa_gsm_sdcch8_demapper.test_downlink<br><br>Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348<br>---<br>M lib/demapping/universal_ctrl_chans_demapper_impl.cc<br>M python/qa_gsm_bcch_ccch_sdcch4_demapper.py<br>M python/qa_gsm_sdcch8_demapper.py<br>3 files changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/46/14946/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lib/demapping/universal_ctrl_chans_demapper_impl.cc b/lib/demapping/universal_ctrl_chans_demapper_impl.cc</span><br><span>index 98bcc9c..a6ab956 100644</span><br><span>--- a/lib/demapping/universal_ctrl_chans_demapper_impl.cc</span><br><span>+++ b/lib/demapping/universal_ctrl_chans_demapper_impl.cc</span><br><span>@@ -140,7 +140,7 @@</span><br><span>             {</span><br><span>                 new_header->sub_type = ch_type;</span><br><span>             }</span><br><span style="color: hsl(0, 100%, 40%);">-            new_header->sub_slot = subslots[fn_mod51 + (51 * (frame_nr % 2))];</span><br><span style="color: hsl(120, 100%, 40%);">+            new_header->sub_slot = subslots[fn_mod102];</span><br><span>             </span><br><span>             if(fn_mod51>=fn51_start && fn_mod51<=fn51_stop)</span><br><span>             {</span><br><span>diff --git a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py</span><br><span>index f51c7bf..a3688c7 100644</span><br><span>--- a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py</span><br><span>+++ b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py</span><br><span>@@ -37,7 +37,6 @@</span><br><span>     def tearDown (self):</span><br><span>         self.tb = None</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    @unittest.expectedFailure</span><br><span>     def test_downlink (self):</span><br><span>         """</span><br><span>            BCCH_CCCH_SDCCH4 demapper downlink test</span><br><span>diff --git a/python/qa_gsm_sdcch8_demapper.py b/python/qa_gsm_sdcch8_demapper.py</span><br><span>index aacb1a8..b5c5ff5 100644</span><br><span>--- a/python/qa_gsm_sdcch8_demapper.py</span><br><span>+++ b/python/qa_gsm_sdcch8_demapper.py</span><br><span>@@ -37,7 +37,6 @@</span><br><span>     def tearDown (self):</span><br><span>         self.tb = None</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    @unittest.expectedFailure</span><br><span>     def test_downlink (self):</span><br><span>         """</span><br><span>            SDCCH8 demapper downlink test</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/gr-gsm/+/14946">change 14946</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/gr-gsm/+/14946"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: gr-gsm </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348 </div>
<div style="display:none"> Gerrit-Change-Number: 14946 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vasil Velichkov <vvvelichkov@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Piotr Krysik <ptrkrysik@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>