Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests
fixeria
gerrit-no-reply at lists.osmocom.org
Tue Jul 23 12:53:16 UTC 2019
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 )
Change subject: msc: use f_expect_clear() in check IMEI tests
......................................................................
Patch Set 1:
(2 comments)
Fine with me in general, excluding the expected results.
https://gerrit.osmocom.org/#/c/14900/1//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/#/c/14900/1//COMMIT_MSG@15
PS1, Line 15: Update expected-results.xml, with latest from jenkins
IMHO, this should be done in a separate change before this one.
https://gerrit.osmocom.org/#/c/14900/1/msc/expected-results.xml
File msc/expected-results.xml:
https://gerrit.osmocom.org/#/c/14900/1/msc/expected-results.xml@a35
PS1, Line 35:
... otherwise it looks like this patch also fixes this and some other unrelated test cases.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b
Gerrit-Change-Number: 14900
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jul 2019 12:53:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190723/ba20ccc9/attachment.html>
More information about the gerrit-log
mailing list