Change in ...osmo-bts[master]: pcu_sock: Don't discard fractional part of link_quality

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 21 10:06:32 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14873


Change subject: pcu_sock: Don't discard fractional part of link_quality
......................................................................

pcu_sock: Don't discard fractional part of link_quality

When comparing the received link quality with the minimum threshold,
don't discard any fractional part by first converting to float and then
dividing by 10 (rather than the opposite order).

Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57
Closes: CID#171992
---
M src/common/pcu_sock.c
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/14873/1

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 39b4568..7f5fed3 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -320,18 +320,19 @@
 
 int pcu_tx_data_ind(struct gsm_bts_trx_ts *ts, uint8_t sapi, uint32_t fn,
 	uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len,
-	int8_t rssi, uint16_t ber10k, int16_t bto, int16_t lqual)
+	int8_t rssi, uint16_t ber10k, int16_t bto, int16_t lqual_cb)
 {
 	struct msgb *msg;
 	struct gsm_pcu_if *pcu_prim;
 	struct gsm_pcu_if_data *data_ind;
 	struct gsm_bts *bts = ts->trx->bts;
+	float lqual = (float) lqual_cb / 10.0f;
 
 	LOGP(DPCU, LOGL_DEBUG, "Sending data indication: sapi=%s arfcn=%d block=%d data=%s\n",
 	     sapi_string[sapi], arfcn, block_nr, osmo_hexdump(data, len));
 
-	if (lqual / 10 < bts->min_qual_norm) {
-		LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %f, dropping packet\n",
+	if (lqual < bts->min_qual_norm) {
+		LOGP(DPCU, LOGL_DEBUG, "Link quality %f is below threshold %f, dropping packet\n",
 			lqual, bts->min_qual_norm);
 		return 0;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57
Gerrit-Change-Number: 14873
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/e6d3320b/attachment.html>


More information about the gerrit-log mailing list