<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/14873">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_sock: Don't discard fractional part of link_quality<br><br>When comparing the received link quality with the minimum threshold,<br>don't discard any fractional part by first converting to float and then<br>dividing by 10 (rather than the opposite order).<br><br>Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57<br>Closes: CID#171992<br>---<br>M src/common/pcu_sock.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/14873/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index 39b4568..7f5fed3 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -320,18 +320,19 @@</span><br><span> </span><br><span> int pcu_tx_data_ind(struct gsm_bts_trx_ts *ts, uint8_t sapi, uint32_t fn,</span><br><span>   uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len,</span><br><span style="color: hsl(0, 100%, 40%);">-   int8_t rssi, uint16_t ber10k, int16_t bto, int16_t lqual)</span><br><span style="color: hsl(120, 100%, 40%);">+     int8_t rssi, uint16_t ber10k, int16_t bto, int16_t lqual_cb)</span><br><span> {</span><br><span>    struct msgb *msg;</span><br><span>    struct gsm_pcu_if *pcu_prim;</span><br><span>         struct gsm_pcu_if_data *data_ind;</span><br><span>    struct gsm_bts *bts = ts->trx->bts;</span><br><span style="color: hsl(120, 100%, 40%);">+     float lqual = (float) lqual_cb / 10.0f;</span><br><span> </span><br><span>  LOGP(DPCU, LOGL_DEBUG, "Sending data indication: sapi=%s arfcn=%d block=%d data=%s\n",</span><br><span>          sapi_string[sapi], arfcn, block_nr, osmo_hexdump(data, len));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  if (lqual / 10 < bts->min_qual_norm) {</span><br><span style="color: hsl(0, 100%, 40%);">-            LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %f, dropping packet\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ if (lqual < bts->min_qual_norm) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGP(DPCU, LOGL_DEBUG, "Link quality %f is below threshold %f, dropping packet\n",</span><br><span>                         lqual, bts->min_qual_norm);</span><br><span>               return 0;</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/14873">change 14873</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/14873"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57 </div>
<div style="display:none"> Gerrit-Change-Number: 14873 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>