Change in ...osmo-pcu[master]: schedule: do not use DL TBF with no extra data

lynxis lazus gerrit-no-reply at lists.osmocom.org
Wed Jul 10 20:43:46 UTC 2019


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14747


Change subject: schedule: do not use DL TBF with no extra data
......................................................................

schedule: do not use DL TBF with no extra data

There is no need in sending acked packets.

TODO: write a test case for this

Change-Id: I8bbd4570f70bb712edd2f78520bf1643c9157aff
---
M src/gprs_rlcmac_sched.cpp
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/14747/1

diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp
index 57756e3..61d3e39 100644
--- a/src/gprs_rlcmac_sched.cpp
+++ b/src/gprs_rlcmac_sched.cpp
@@ -265,6 +265,9 @@
 		if (tbf->m_wait_confirm)
 			continue;
 
+		if (tbf->window()->window_empty() && !tbf->have_data())
+			continue;
+
 		age = tbf->frames_since_last_poll(fn);
 
 		/* compute priority */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8bbd4570f70bb712edd2f78520bf1643c9157aff
Gerrit-Change-Number: 14747
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190710/d47dc0ea/attachment.html>


More information about the gerrit-log mailing list