Change in ...osmo-pcu[master]: Use libosmocore for IMSI parsing

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Jul 10 18:16:01 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/13395 )

Change subject: Use libosmocore for IMSI parsing
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp@88 
PS2, Line 88: 16
In the recent libosmocore we have OSMO_IMSI_BUF_SIZE.


https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp@116 
PS2, Line 116: 16
How about sizeof(imsi)?


https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp@179 
PS2, Line 179: 16
same



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/13395
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1
Gerrit-Change-Number: 13395
Gerrit-PatchSet: 2
Gerrit-Owner: Max <suraev at alumni.ntnu.no>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: msuraev <suraev at alumni.ntnu.no>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 18:16:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190710/fc277504/attachment.html>


More information about the gerrit-log mailing list