<p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/13395">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp">File src/gprs_bssgp_pcu.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp@88">Patch Set #2, Line 88:</a> <code style="font-family:monospace,monospace">16</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In the recent libosmocore we have OSMO_IMSI_BUF_SIZE.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp@116">Patch Set #2, Line 116:</a> <code style="font-family:monospace,monospace">16</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How about sizeof(imsi)?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp@179">Patch Set #2, Line 179:</a> <code style="font-family:monospace,monospace">16</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/13395">change 13395</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/13395"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 </div>
<div style="display:none"> Gerrit-Change-Number: 13395 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <suraev@alumni.ntnu.no> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: msuraev <suraev@alumni.ntnu.no> </div>
<div style="display:none"> Gerrit-CC: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Jul 2019 18:16:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>